Add ARIA reflection tests for ariaBrailleLabel and ariaBrailleRoleDescription - #42751
Merged
Merged
Conversation
8 tasks
pkra
pushed a commit
to w3c/aria
that referenced
this pull request
Jan 9, 2024
…ions (#2039) This adds the following string reflections to ARIAMixin: - `ariaBrailleLabel` -> `aria-braillelabel` - `ariaBrailleRoleDescription` -> `aria-brailleroledescription` These reflections are already implemented in Chromium (see [here](https://source.chromium.org/chromium/chromium/src/+/main:out/fuchsia-Debug/gen/third_party/blink/renderer/bindings/modules/v8/v8_element.cc;l=1201;drc=168fe20dbf8ab7e47e36db5e528ec3c95c2f8af0) and [here](https://source.chromium.org/chromium/chromium/src/+/main:out/fuchsia-Debug/gen/third_party/blink/renderer/bindings/modules/v8/v8_element.cc;l=1228;drc=168fe20dbf8ab7e47e36db5e528ec3c95c2f8af0)), but not yet in WebKit or Firefox. The purpose of this PR is to align with the de-facto behavior of Chromium. I don't see a strong reason for the spec not to include these particular reflections. (If there is one, please let me know!) See also: #923 # PR tracking Check these when the relevant issue or PR has been made, OR after you have confirmed the related change is not necessary (add N/A). Leave unchecked if you are unsure. Read the [Process Document](https://github.com/w3c/aria/wiki/ARIA-WG-Process-Document/_edit) or [Test Overview](https://github.com/w3c/aria/wiki/ARIA-Test-Overview) for more information. * [x] Related Core AAM Issue/PR: does not apply * [x] Related AccName Issue/PR: does not apply * [x] Related APG Issue/PR: does not apply * [x] Any other dependent changes? no. # Implementation tracking * [x] "author MUST" tests: does not apply * [x] "user agent MUST" tests: web-platform-tests/wpt#42751 * [x] Browser implementations (link to issue or when done, link to commit): * WebKit: No (https://bugs.webkit.org/show_bug.cgi?id=263663) * Gecko: No (https://bugzilla.mozilla.org/show_bug.cgi?id=1861201) * Blink: [here](https://source.chromium.org/chromium/chromium/src/+/main:out/fuchsia-Debug/gen/third_party/blink/renderer/bindings/modules/v8/v8_element.cc;l=1201;drc=168fe20dbf8ab7e47e36db5e528ec3c95c2f8af0) and [here](https://source.chromium.org/chromium/chromium/src/+/main:out/fuchsia-Debug/gen/third_party/blink/renderer/bindings/modules/v8/v8_element.cc;l=1228;drc=168fe20dbf8ab7e47e36db5e528ec3c95c2f8af0) * [x] Does this need AT implementations? no.
foolip
approved these changes
Jan 11, 2024
Contributor
|
@foolip @nolanlawson et al, please get some accessibility-focused reviewers to approve the aria-related tests. While these tests are needed, the change the Interop 2024 deltas unexpectedly, after the test list was agreed upon. I would have liked to alert the accessibility engineering teams at each browser and get them to sign off on any Interop 2024 deltas. We still could have checked in the tests, but if there was doubt about which work would be done for 2024, we might have moved these to a different file not already tagged with Thanks. |
Contributor
|
Now wondering if I can add suggested reviewers at an individual file level in the META.yml. |
marcoscaceres
pushed a commit
that referenced
this pull request
Feb 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per w3c/aria#2039
Adds reflection tests for
ariaBrailleLabel<->aria-braillelabelandariaBrailleRoleDescription<->aria-brailleroledescription.