Turn Http prefix tests to non-tentative, with predictable failure messages - #53436
Merged
Conversation
annevk
approved these changes
Jun 27, 2025
annevk
left a comment
Member
There was a problem hiding this comment.
I suspect you can just use let http_prefix_counter here, but this is okay.
Member
|
Firefox stability checks are failing on /cookies/partitioned-cookies/partitioned-cookies-a-b-a-embed.tentative.https.html, because it uses cookies/resources/cookie-helper.sub.js. @yoavweiss are you confident the flakiness is preexisting or could it be caused by these changes? |
Contributor
Author
|
My changes modify the cookie value but keep it unique per test. Looking at the flaky failures I don't see how they can be related to that. |
Member
|
@yoavweiss thanks for taking a look. I'll admin merge on the assumption that this is preexisting then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As httpwg/http-extensions#3110 had landed, we can mark the relevant tests as non-tentative.
On top of that, their current failure messages are not predictable, making them hard to land in WebKit (where predictable expectations are expected).
This change renames the tests, and makes their failure messages predictable.