Add test coverage for deselecting other option elements - #58981
Merged
Conversation
chromium-wpt-export-bot
marked this pull request as ready for review
April 3, 2026 22:09
Checking that clicking an option in a customizable single-select changes select.value is probably good enough, but since it was questioned whether this is tested or not, I want to add detailed test coverage which proves that the other option is deselected. Context: whatwg/html#12069 (comment) Change-Id: Iab6b6f6e7dfc3fabe8623083531ee15f372681ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7726423 Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by: David Grogan <dgrogan@chromium.org> Auto-Submit: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1609971}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-7726423
branch
from
April 3, 2026 22:10
59ae66f to
3d946bd
Compare
wpt-pr-bot
approved these changes
Apr 3, 2026
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checking that clicking an option in a customizable single-select changes
select.value is probably good enough, but since it was questioned
whether this is tested or not, I want to add detailed test coverage
which proves that the other option is deselected.
Context: whatwg/html#12069 (comment)
Change-Id: Iab6b6f6e7dfc3fabe8623083531ee15f372681ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7726423
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Auto-Submit: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1609971}