Add additional context to --debug log messages#28
Merged
Conversation
In the `main()` method, in debug mode, we print out the argument dictionaries a few times but without context for which one is which. This commit adds an extra line of debug logging each time that indicates from which point in the process the args are originating. Hopefully this will expedite any arg parsing debugging. I've also removed one line of unused code that created an intermediate object for the argparse object.
|
|
binaryaaron
approved these changes
Apr 13, 2018
|
Great, thank you! I'll send a new release to Pypi. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the
main()method, in debug mode, we print out the argumentdictionaries a few times but without context for which one is which.
This commit adds an extra line of debug logging each time that indicates
from which point in the process the args are originating. Hopefully this
will expedite any arg parsing debugging.
I've also removed one line of unused code that created an intermediate
object for the argparse object.