Fixing flip lens feature in CameraKit - #56
Merged
Conversation
anistarsung
commented
Aug 23, 2017
- Adding a demo feature for verify flip lens feature.
- Fixing output image result with wrong mirror mode problem.
2. Fixing output image result with wrong mirror mode problem.
kenobilyh
approved these changes
Aug 23, 2017
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
========================================
- Coverage 26.42% 25% -1.43%
========================================
Files 29 29
Lines 2331 2164 -167
Branches 318 318
========================================
- Hits 616 541 -75
+ Misses 1715 1584 -131
- Partials 0 39 +39
Continue to review full report at Codecov.
|
Author
|
Good to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.