Fix Pull-To-Refresh on iOS11. - #59
Merged
Merged
Conversation
Pull-to-refresh triggers reloading immediately even pulling down for a very short distance then releasing on iOS 11. This PR fixes it. The root cause is that safe area insets are introduced in iOS 11. We should respect it as the contentInsets doesn't seem to adjust anymore. If we're going to use the old way to adjust contentInsets, contentInsetAdjustmentBehavior should set to UIScrollViewContentInsetAdjustmentNever, then adjust contentInsets in the old way. Pull-To-Refresh will just work as expected.
|
Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄 |
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
=====================================
Coverage 25% 25%
=====================================
Files 29 29
Lines 2164 2164
Branches 318 318
=====================================
Hits 541 541
Misses 1584 1584
Partials 39 39
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull-to-refresh triggers reloading immediately even pulling down for a
very short distance then releasing on iOS 11. This PR fixes it.
The root cause is that safe area insets are introduced in iOS 11. We
should respect it as the contentInsets doesn't seem to adjust anymore.
If we're going to use the old way to adjust contentInsets,
contentInsetAdjustmentBehavior should set to
UIScrollViewContentInsetAdjustmentNever, then adjust contentInsets in
the old way. Pull-To-Refresh will just work as expected.