Add RGB, ARGB and RGBA methods for the category of UIColor. - #65
Conversation
|
Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄 |
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
==========================================
+ Coverage 24.94% 25.72% +0.78%
==========================================
Files 29 29
Lines 2169 2239 +70
Branches 320 320
==========================================
+ Hits 541 576 +35
- Misses 1589 1624 +35
Partials 39 39
Continue to review full report at Codecov.
|
qcl
left a comment
There was a problem hiding this comment.
I'd done my review. And I hope you can also complete the test for those new methods.
| /** | ||
| * @brief Create a color by hex string. | ||
| * @brief Create a color by hex string. The returned color is undefined if hexString is invalid. | ||
| * The behaviour is the same as ADKColorWithRGBHexString:, but ADKColorWithRGBHexString is preferred. |
There was a problem hiding this comment.
Second ADKColorWithRGBHexString missed its :.
|
I've fixed the typo and applied related tests. |
|
BTW, I also upgrade IPHONEOS_DEPLOYMENT_TARGET of test target from 7.0 to 8.0 to build the tests successfully. |
|
|
||
| SPEC_END No newline at end of file | ||
| describe(@"Test ADKColorWithRGBHexString", ^{ | ||
| it(@"given color with 7b0099, should get string 7B0099", ^{ |
There was a problem hiding this comment.
It should be given string 7B0099, should get color with 7b0099.
| }); | ||
|
|
||
| describe(@"Test ADKColorWithARGBHexString", ^{ | ||
| it(@"given color with EE7b0099, should get string EE7B0099", ^{ |
| }); | ||
|
|
||
| describe(@"Test ADKColorWithRGBAHexString", ^{ | ||
| it(@"given color with 7b0099EE, should get string 7B0099EE", ^{ |
|
I've updated the test description. Thanks. |
No description provided.