Skip to content

Fix error lines extraction & Fix testcases - #10

Merged
youknowone merged 2 commits into
youknowone:lib_updaterfrom
moreal:lib_updater
Jan 19, 2026
Merged

Fix error lines extraction & Fix testcases#10
youknowone merged 2 commits into
youknowone:lib_updaterfrom
moreal:lib_updater

Conversation

@moreal

@moreal moreal commented Jan 19, 2026

Copy link
Copy Markdown

This pull request does two things. First, fix the test case for the test_auto_mark.py test. This is because it actually outputs like test_foo (test_pkg.TestClass.test_foo).

Another thing is that "-----" is also recognized as the end of error lines. For the last line, as in the example below, it ends with a dash, so this is reflected.

======================================================================
FAIL: test_reverse_iterator_picking (test.test_array.UnsignedShortTest.test_reverse_iterator_picking)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/moreal/github/RustPython/RustPython-tmp/crates/pylib/Lib/test/test_array.py", line 390, in test_reverse_iterator_picking
    self.assertEqual(type(it), type(itorig))
                                    ^^^^^^
AssertionError: <class 'list_reverseiterator'> != <class 'reversed'>

----------------------------------------------------------------------

@coderabbitai

coderabbitai Bot commented Jan 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@moreal moreal mentioned this pull request Jan 19, 2026
Merged
youknowone
youknowone approved these changes Jan 19, 2026
View reviewed changes

@youknowone youknowone left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@youknowone
youknowone merged commit 212d54f into youknowone:lib_updater Jan 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@moreal @youknowone