Feat: adjust max file size to have customizable limit - #1648

@Benebo7 is attempting to deploy a commit to the Rohan Verma's projects Team on Vercel.

A member of the Team first needs to authorize it.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands.}

I am actually curious about storage limit per workspace specifically on official cloud, but I am not certain about whether it is a architectural decision or a missing config. Whatever, I would be happy to implement it if wanted...

@Yigtwxx Thanks for this review, I'm gonna fix that by now

It is probably clean now, and i took this opportunity to fix a biome error due to a wrong positioned import that I made on some PR of mine.

Re-checked e768895 locally. The fixes look right — the backend now degrades to 500 MB with a warning instead of crashing at import, and the frontend guard survives both MAX_FILE_SIZE_MB= and MAX_FILE_SIZE_MB=500MB. One real CI failure left, and two red checks that are not yours.

The one thing to fix: ruff-format

Backend Quality is failing on documents_routes.py. Reproduced with the pinned hook version (ruff-pre-commit v0.12.5, and 0.15.x agrees):

$ uv run ruff format --diff app/routes/documents_routes.py
--- app/routes/documents_routes.py
+++ app/routes/documents_routes.py
@@ -56,6 +56,7 @@

 router = APIRouter()

+
 # Per-file upload cap. Operators raise MAX_FILE_SIZE_MB when self-hosting on
 # hardware that can take it; the frontend reads the same value for its
 # pre-upload check.
@@ -66,10 +67,16 @@
     try:
         value = int(raw)
     except ValueError:
-        logger.warning("Invalid MAX_FILE_SIZE_MB=%r, falling back to %d MB", raw, default)
+        logger.warning(
+            "Invalid MAX_FILE_SIZE_MB=%r, falling back to %d MB", raw, default
+        )
         return default
     if value <= 0:
-        logger.warning("MAX_FILE_SIZE_MB must be positive, got %d, falling back to %d MB", value, default)
+        logger.warning(
+            "MAX_FILE_SIZE_MB must be positive, got %d, falling back to %d MB",
+            value,
+            default,
+        )
         return default
     return value

Two blank lines before the comment block (the comment belongs to the function, so the separation goes above it), and both logger.warning calls exceed the configured line-length = 88. uv run ruff format app/routes/documents_routes.py from surfsense_backend/ applies exactly this.

ruff check is clean on both files you touched — I ran the pinned 0.12.5 against documents_routes.py and test_upload_limits.py and got All checks passed!.

Not caused by this PR

Frontend Quality — the 12 biome errors are all in files this PR does not touch:

components/documents/DocumentsEmptyState.tsx
components/documents/DocumentsSearchResults.tsx
components/documents/DocumentsView.tsx
components/documents/HighlightedText.tsx
lib/documents/documents-view-model.ts
tests/helpers/ui/connector-popup.ts

Extracting those six files straight from current origin/dev and running the pinned npx @biomejs/biome@2.4.6 check --diagnostic-level=error on them reproduces the failures, so dev itself is currently biome-dirty and any PR touching surfsense_web/ inherits this. Your three changed web files pass that same command cleanly.

Integration Tests — one failure, test_converge.py::test_identical_content_at_two_paths_yields_two_documents, with redis.exceptions.ConnectionError: ... connecting to localhost:6379. Infrastructure, not the upload path (230 passed, 1 failed).

Two small notes

surfsense_web/lib/error-toast.ts — that import-order fix already landed on dev in #1666 with the identical reordering. Merging dev into your branch will make it disappear from the diff; no need to carry it here.

useExhaustiveDependencies — biome flags addFiles because MAX_FILE_SIZE_BYTES is now a component-scope useMemo value rather than the module constant it used to be:

components/sources/DocumentUploadTab.tsx:169:19 lint/correctness/useExhaustiveDependencies
  ! This hook does not specify its dependency on MAX_FILE_SIZE_BYTES.

That is my fault — I suggested [t, maxFileSizeMB] while it was still a module constant, and the useMemo changed the rule's answer. It is configured as "warn" and the CI hook runs --diagnostic-level=error, so it will not fail the gate, but [t, maxFileSizeMB, MAX_FILE_SIZE_BYTES] silences it. If you touch that line anyway, maxFileSizeBytes reads better than a SCREAMING_CASE name for something that is no longer a constant.

Hope that's enough

f3e5ecb is right on both counts — ruff-format now passes, and maxFileSizeBytes with [t, maxFileSizeMB, maxFileSizeBytes] clears the biome warning. Nothing left in your diff.

I owe you a correction on one thing I said, though.

ruff check is not clean — and it is not your code

I ran the pinned ruff against documents_routes.py on your branch, which is still based on the older dev, and reported it clean. CI checks out the merge of your branch with current dev, and on that merge the file has a pre-existing I001:

$ git fetch origin refs/pull/1648/merge:m
$ uvx ruff@0.12.5 check --fix --diff <documents_routes.py from that merge>
-from app.knowledge_store.paths import virtual_path_to_doc
 from app.auth.context import AuthContext
 from app.db import (
     ...
 )
+from app.knowledge_store.paths import virtual_path_to_doc

Would fix 1 error.

That misplaced import is on dev already, nowhere near your helper function. Because the hook lints every file a PR touches rather than the lines it changed, your PR inherits it — the same mechanism as the biome failures.

So this was the last red check that could plausibly have been yours, and it is not. Sorry for pointing you at a clean result measured on the wrong tree.

Both dev-side breakages now have PRs

• fix(web): restore biome compliance in the documents view #1671 — the 12 biome errors in the documents view. Frontend Quality and Quality Gate are green on it.
• fix(backend): restore ruff compliance across surfsense_backend #1672 — 21 ruff violations across the backend, documents_routes.py among them, plus 11 files with ruff format drift.

If you would rather not wait on those, moving that single import line in your own branch turns Backend Quality green immediately; it becomes a no-op once #1672 lands. Either way your PR itself is done.

The remaining failure is the Redis ConnectionError in test_converge.py, which is infrastructure.

@Benebo7 @Yigtwxx Thanks