fix(web): restore biome compliance in the documents view - #1671

Summary

biome-check-web runs npx @biomejs/biome@2.4.6 check --diagnostic-level=error . over the entire surfsense_web tree, so the twelve diagnostics currently sitting in the documents view fail Frontend Quality on every PR that touches anything under surfsense_web/, regardless of what that PR changed. This restores a clean run.

On current dev (339fe12):

$ npx @biomejs/biome@2.4.6 check --diagnostic-level=error .
components/documents/DocumentsEmptyState.tsx:12:4     lint/a11y/useAriaPropsSupportedByRole
components/documents/DocumentsEmptyState.tsx:37:4     lint/a11y/useSemanticElements
components/documents/DocumentsEmptyState.tsx          format
components/documents/DocumentsSearchResults.tsx:3:1   assist/source/organizeImports
components/documents/DocumentsSearchResults.tsx:26:77 lint/a11y/useSemanticElements
components/documents/DocumentsSearchResults.tsx       format
components/documents/DocumentsView.tsx                format
components/documents/FolderPickerDialog.tsx:3:1       assist/source/organizeImports
components/documents/HighlightedText.tsx              format
hooks/use-documents-view-model.ts:3:1                 assist/source/organizeImports
lib/documents/documents-view-model.ts                 format
tests/helpers/ui/connector-popup.ts                   format
Found 12 errors.

The same twelve show up in the Frontend Quality logs of unrelated PRs — for example #1648, which touches three other web files and inherits all of them.

Changes

Nine mechanical (biome check --write). Six files were formatted at a narrower line width than the configured lineWidth: 100, and three had unsorted imports. No hand edits.

Three a11y rules with no automatic fix. All three resolve to the native <output> element:

• DocumentsEmptyState.tsx:12 — the loading skeleton carried aria-label on a role-less <div>, which useAriaPropsSupportedByRole rejects.
• DocumentsEmptyState.tsx:37 and DocumentsSearchResults.tsx:26 — role="status", which useSemanticElements wants expressed as <output>.

<output> has the implicit status role and accepts aria-label / aria-busy / aria-live, so what a screen reader announces is unchanged. role="status" is dropped where it became redundant, and block is added on the two that replaced block-level elements (<output> is inline by default) so layout is untouched.

Testing

$ cd surfsense_web && npx @biomejs/biome@2.4.6 check --diagnostic-level=error .
Checked 1066 files in 797ms. No fixes applied.

Clean across the whole tree — the exact command the pre-commit hook runs.

npx tsc --noEmit reports the same 38 pre-existing errors before and after; none of them are in the eight files touched here. They are unrelated to this change (missing @/.source/server codegen, ElectronAPI globals, and similar) and CI does not run tsc, so they are left alone.

High-level PR Summary

This PR fixes 12 Biome linting errors in the documents view that were blocking Frontend Quality checks across all PRs touching the surfsense_web/ directory. The changes include nine mechanical formatting and import organization fixes applied via biome check --write, and three accessibility improvements that replace non-semantic elements with the native <output> element to satisfy a11y rules (useAriaPropsSupportedByRole and useSemanticElements). The accessibility changes maintain the same screen reader behavior while achieving Biome compliance.

⏱️ Estimated Review Time: 15-30 minutes