Skip to content

Update versions of towncrier and sphinx-changelog#2018

Merged
namurphy merged 5 commits into
PlasmaPy:mainfrom
namurphy:update-towncrier
Mar 16, 2023
Merged

Update versions of towncrier and sphinx-changelog#2018
namurphy merged 5 commits into
PlasmaPy:mainfrom
namurphy:update-towncrier

Conversation

@namurphy

Copy link
Copy Markdown
Member

There had been an incompatibility between recent releases of towncrier and sphinx-changelog, so we had previously pinned the versions of these packages. The most recent release of sphinx-changelog should have resolved this incompatibility, so it should now be interoperable with the most recent release of towncrier. This PR sets the most recent versions of towncrier and sphinx-changelog as lower limits in the requirements.

Closes #1851. See also #1711 and #1717.

@namurphy namurphy added the no changelog entry needed For PRs that should not have a changelog entry label Mar 14, 2023
@namurphy namurphy marked this pull request as ready for review March 14, 2023 23:57
@namurphy namurphy requested review from a team and StanczakDominik as code owners March 14, 2023 23:57
@namurphy namurphy requested review from ejohnson-96 and removed request for a team and StanczakDominik March 15, 2023 00:56

@ejohnson-96 ejohnson-96 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@ejohnson-96 ejohnson-96 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflicts arise when updating

@namurphy

Copy link
Copy Markdown
Member Author

@ejohnson-96 — just fixed the conflicts that resulted from merging #2019. Thanks!

@codecov

codecov Bot commented Mar 15, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage has no change and project coverage change: +98.33 🎉

Comparison is base (7d7a20d) 0.00% compared to head (62432f4) 98.33%.

Additional details and impacted files
@@            Coverage Diff            @@
##           main    #2018       +/-   ##
=========================================
+ Coverage      0   98.33%   +98.33%     
=========================================
  Files         0       96       +96     
  Lines         0     8503     +8503     
=========================================
+ Hits          0     8361     +8361     
- Misses        0      142      +142     

see 96 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@namurphy namurphy requested a review from ejohnson-96 March 15, 2023 22:45

@ejohnson-96 ejohnson-96 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ejohnson-96 ejohnson-96 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@namurphy namurphy enabled auto-merge (squash) March 16, 2023 17:05
@namurphy namurphy merged commit c48ca65 into PlasmaPy:main Mar 16, 2023
@namurphy namurphy deleted the update-towncrier branch May 1, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog entry needed For PRs that should not have a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove upper limit on allowed versions of towncrier

2 participants