Remove upper limit on sphinx-gallery and specify documentation-related requirements#2019
Merged
Merged
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2019 +/- ##
=======================================
Coverage 98.33% 98.33%
=======================================
Files 96 96
Lines 8503 8503
=======================================
Hits 8361 8361
Misses 142 142 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
sphinx-gallerysphinx-gallery and specify documentation-related requirements
Member
Author
|
The examples page for the Read the Docs documentation build for this pull request appear to be fine, so this PR should be good to go! |
Member
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we placed an upper limit on
sphinx-gallerybecause using the newer version led to the thumbnails for our example galleries to show up incorrectly. This PR removes the upper limit onsphinx-gallery.This PR also sets some new minimum versions of packages for building the documentation, since it may be updates to
sphinx_rtd_themeornbsphinxthat are what fixed the problem. It's worth noting that the new requirements for several of these packages are for the most recent release, but since this is for optional requirements for the documentation, I don't expect this to cause any problems.Related to #1654. Closes #1972.