Disable cmdlets that are not supported under unix system by chunqingchen · Pull Request #5083 · PowerShell/PowerShell

Chunqing Chen (chunqingchen) · 2017-10-11T08:44:13Z

resolve #4355

Removed cmdlets from IntialSessionState.cs so they will not be available on unix platforms.

Ilya (iSazonov) · 2017-10-11T13:34:34Z

Usually we exclude not ported cmdlets with #if !UNIX (or exclude whole file in csproj) and remove from psd1

Also we need correct tests in DefaultCommands.Tests.ps1

Chunqing Chen (chunqingchen) · 2017-10-18T07:14:13Z

Ilya (@iSazonov) in issue #4355 you mentioned not implantation exception should be added instead of excluding the cmdlets. Is that not the case now?

Ilya (iSazonov) · 2017-10-18T10:59:58Z

Chunqing Chen (@chunqingchen) Sorry, my comment was not approved. I remember Dongbo Wang (@daxian-dbw) said that it is better exclude code in csproj - it is easy to track. Dongbo Wang (@daxian-dbw) Could you confirm?

Aditya Patwardhan (adityapatwardhan) · 2017-10-17T17:32:59Z

Extra line added.

Aditya Patwardhan (adityapatwardhan) · 2017-10-17T17:35:16Z

Would ! Platform.IsWindows work?

Aditya Patwardhan (adityapatwardhan) · 2017-10-23T19:27:17Z

For consistency sake, can we use non-windows path here?

Aditya Patwardhan (adityapatwardhan) · 2017-10-23T19:27:27Z

For consistency sake, can we use non-windows path here?

Chunqing Chen (chunqingchen) · 2017-10-27T10:44:23Z

Aditya Patwardhan (@adityapatwardhan) your comments are resolved.

Travis Plunk (TravisEz13) · 2017-10-28T17:50:27Z

The last commit is lot linked to a github account. Please resolve.

Aditya Patwardhan (adityapatwardhan) · 2017-10-31T22:37:08Z

Chunqing Chen (@chunqingchen) The title and the description needs to be updated to match the implementation.

… tests to defaultcommands.tests.ps1

Chunqing Chen (chunqingchen) · 2017-11-01T08:56:00Z

Aditya Patwardhan (@adityapatwardhan) updated

Ilya (iSazonov) · 2017-11-01T10:11:23Z

        public void LoadCommandStop(string Name) { WriteEvent(26, Name); }
    }
-}
+}


Please add new line at EOF.

Chunqing Chen (@chunqingchen) Sorry, we should add newline after the last brace not before.

Ilya (iSazonov) · 2017-11-01T10:11:35Z

        Test-Path Function:more | Should Be $true
    }
-}
+}


Please add new line at EOF.

Chunqing Chen (@chunqingchen) Sorry, we should add newline after the last brace not before.

Chunqing Chen (chunqingchen) · 2017-11-01T20:57:38Z

Ilya (@iSazonov) your comment is resolved

Ilya (iSazonov)

Leave a comment

Ilya (iSazonov) · 2017-11-02T03:09:58Z

        Test-Path Function:more | Should Be $true
    }
-}
+}


Chunqing Chen (@chunqingchen) Sorry, we should add newline after the last brace not before.

Ilya (iSazonov) · 2017-11-02T03:10:09Z

        public void LoadCommandStop(string Name) { WriteEvent(26, Name); }
    }
-}
+}


Chunqing Chen (@chunqingchen) Sorry, we should add newline after the last brace not before.

Travis Plunk (TravisEz13) · 2017-11-02T22:53:26Z

missing newline

Travis Plunk (TravisEz13) · 2017-11-02T22:53:43Z

missing newline

Travis Plunk (TravisEz13)

Fix minor issue and it should be good

Chunqing Chen (chunqingchen) · 2017-11-02T23:59:48Z

Travis Plunk (@TravisEz13) new line added.

Ilya (iSazonov)

Should we exclude the code from compilation?

Ilya (iSazonov) · 2017-11-03T03:26:59Z

        public void LoadCommandStart(string Name) { WriteEvent(25, Name); }
        public void LoadCommandStop(string Name) { WriteEvent(26, Name); }
    }
+


Please revert the formatting change and remove the line.

Ilya (iSazonov) · 2017-11-03T03:27:10Z

    It "Should have 'more' as a function" {
        Test-Path Function:more | Should Be $true
    }
+


Please revert the formatting change and remove the line.

Aditya Patwardhan (adityapatwardhan) · 2017-11-06T18:24:02Z

Chunqing Chen (@chunqingchen) Please run all tests using [Feature] in your git commit message.

https://github.com/PowerShell/PowerShell/blob/a1b7f8be3ea4ac7e4f7a67e6261ad68cdb23143d/docs/testing-guidelines/testing-guidelines.md#requesting-additional-tests-for-a-pr

Chunqing Chen (chunqingchen) · 2017-11-08T15:03:28Z

Aditya Patwardhan (@adityapatwardhan) Ilya (@iSazonov) your comments are resolved. Thanks

Ilya (iSazonov) · 2017-11-08T17:37:37Z

I believe the PR need #5379 to pass CI Appveyor.

Aditya Patwardhan (adityapatwardhan) · 2017-11-10T00:25:13Z

Chunqing Chen (@chunqingchen) Can you have a look at the Travis CI failure?

Ilya (iSazonov) · 2017-11-10T18:03:19Z

CI Travis was passed but not reported.

Aditya Patwardhan (adityapatwardhan) · 2017-11-10T18:35:15Z

Merging as CI has passed but webhook did not update status to GitHub.

Vinod Chandru (vinodc) · 2018-02-21T22:38:34Z

Paul Allen (@paulcallen) Would you happen to know if New-PSSessionOption has been disabled? We updated to the latest version from 6.0.0 beta1 and this no longer works. It was previously working great and we have been using it with New-PSSessionOption since PowerShell/psl-omi-provider#67 was merged in.

Dan Travison (dantraMSFT) · 2018-02-22T00:45:09Z

Vinod Chandru (@vinodc) I'll dig into this. For now, you can use [System.Management.Automation.Remoting.PSSessionOption]::new() and populate the returned object.

BTW: What's the use case you have for it on Linux. Perhaps it was missed with the cmdlet was removed.

Vinod Chandru (vinodc) · 2018-02-22T01:07:04Z

Dan Travison (@dantraMSFT) Thanks for the quick response. We are programmatically accessing Office 365 PowerShell cmdlets and in the process our code creates PSSessionOption objects. We can work around this temporarily, but wanted to make sure that the overall implementation itself is still supported for related commands used to connect to Office 365 PowerShell, starting with New-PSSessionOption.

On a broader note, this is related to piped commands failing (#6206), where we were recommended to update PowerShell first to see if we could reproduce the failure on the latest version, which resulted in these new issues coming up.

Drey Tee (dreyTee) · 2019-05-05T18:06:28Z

Paul Allen (@paulcallen) Would you happen to know if New-PSSessionOption has been disabled?

Have same issue when trying to use WINRM from linux without proper server certificate:
Getting error:
Use the PSSessionOption -SkipCACheck and -SkipCNCheck
Trying to use thes options with New-PSSessionOption but can't:
New-PSSessionOption : The term 'New-PSSessionOption' is not recognized as the name of a cmdlet, function, script file, or operable program.
Please advise a workaround a least.

Ilya (iSazonov) · 2019-05-05T18:31:03Z

Drey Tee (@dreyTee) Please open new issue for your question.

…5083) * permanently remove cmdlets that are not supported under Unix and move tests to defaultcommands.tests.ps1

Chunqing Chen (chunqingchen) requested review from Paul Higinbotham (PaulHigin), Dan Travison (dantraMSFT) and Mike Richmond (mirichmo) as code owners October 11, 2017 08:44

Ilya (iSazonov) assigned Aditya Patwardhan (adityapatwardhan) Oct 15, 2017

Aditya Patwardhan (adityapatwardhan) requested changes Oct 23, 2017

View reviewed changes

Chunqing Chen (chunqingchen) force-pushed the bugfix1 branch from 50b001f to 14c93c6 Compare October 27, 2017 10:29

Chunqing Chen (chunqingchen) requested review from Bruce Payette (BrucePay), Travis Plunk (TravisEz13), Dongbo Wang (daxian-dbw) and Jason Shirk (lzybkr) as code owners October 27, 2017 10:29

Chunqing Chen (chunqingchen) force-pushed the bugfix1 branch 2 times, most recently from bd31660 to 17c7418 Compare October 27, 2017 10:40

Chunqing Chen (chunqingchen) force-pushed the bugfix1 branch 2 times, most recently from c8d72b3 to 063b5d1 Compare October 28, 2017 02:16

Chunqing Chen (chunqingchen) force-pushed the bugfix1 branch 3 times, most recently from d8d84b3 to d70bbac Compare October 31, 2017 22:28

Chunqing Chen (chunqingchen) force-pushed the bugfix1 branch 4 times, most recently from 4781090 to 88fd625 Compare November 1, 2017 05:58

perminently remove cmdlets that are not supported under Unix and move…

7fcf03b

… tests to defaultcommands.tests.ps1

Chunqing Chen (chunqingchen) force-pushed the bugfix1 branch from 88fd625 to 7fcf03b Compare November 1, 2017 07:16

Chunqing Chen (chunqingchen) changed the title ~~add notimplementedException to cmdlets that are temporary not support…~~ Disable cmdlets that are not supported under unix system Nov 1, 2017

Ilya (iSazonov) reviewed Nov 1, 2017

View reviewed changes

Ilya (iSazonov) reviewed Nov 2, 2017

View reviewed changes

Travis Plunk (TravisEz13) reviewed Nov 2, 2017

View reviewed changes

Comment thread src/System.Management.Automation/engine/InitialSessionState.cs Outdated

Travis Plunk (TravisEz13) Nov 2, 2017

Copy link
Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing newline

Travis Plunk (TravisEz13) reviewed Nov 2, 2017

View reviewed changes

Comment thread test/powershell/engine/Basic/DefaultCommands.Tests.ps1 Outdated

Travis Plunk (TravisEz13) Nov 2, 2017

Copy link
Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing newline

Travis Plunk (TravisEz13) approved these changes Nov 2, 2017

View reviewed changes

adding new line EOF

c1e1184

Chunqing Chen (chunqingchen) force-pushed the bugfix1 branch from f4eb37a to c1e1184 Compare November 2, 2017 23:58

Ilya (iSazonov) reviewed Nov 3, 2017

View reviewed changes

[Feature] adding new line EOF

ea3d8f6

Aditya Patwardhan (adityapatwardhan) approved these changes Nov 10, 2017

View reviewed changes

Aditya Patwardhan (adityapatwardhan) merged commit 2be13a6 into PowerShell:master Nov 10, 2017

Vinod Chandru (vinodc) mentioned this pull request Feb 22, 2018

pipe for office 365 not working on linux: Get-Mailbox | Get-MailboxPermission #6206

Closed

Uh oh!

Conversation

Chunqing Chen (chunqingchen) commented Oct 11, 2017 • edited by adityapatwardhan Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ilya (iSazonov) commented Oct 11, 2017

Uh oh!

Chunqing Chen (chunqingchen) commented Oct 18, 2017

Uh oh!

Ilya (iSazonov) commented Oct 18, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Chunqing Chen (chunqingchen) commented Oct 27, 2017

Uh oh!

Travis Plunk (TravisEz13) commented Oct 28, 2017

Uh oh!

Aditya Patwardhan (adityapatwardhan) commented Oct 31, 2017

Uh oh!

Chunqing Chen (chunqingchen) commented Nov 1, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Chunqing Chen (chunqingchen) commented Nov 1, 2017

Uh oh!

Ilya (iSazonov) left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Travis Plunk (TravisEz13) left a comment

Choose a reason for hiding this comment

Uh oh!

Chunqing Chen (chunqingchen) commented Nov 2, 2017

Uh oh!

Ilya (iSazonov) left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Aditya Patwardhan (adityapatwardhan) commented Nov 6, 2017

Uh oh!

Chunqing Chen (chunqingchen) commented Nov 8, 2017

Uh oh!

Ilya (iSazonov) commented Nov 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Aditya Patwardhan (adityapatwardhan) commented Nov 10, 2017

Uh oh!

Ilya (iSazonov) commented Nov 10, 2017

Uh oh!

Aditya Patwardhan (adityapatwardhan) commented Nov 10, 2017

Uh oh!

Vinod Chandru (vinodc) commented Feb 21, 2018

Uh oh!

Dan Travison (dantraMSFT) commented Feb 22, 2018

Uh oh!

Vinod Chandru (vinodc) commented Feb 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Chunqing Chen (chunqingchen) commented Oct 11, 2017 •

edited by adityapatwardhan

Loading

Ilya (iSazonov) left a comment •

edited

Loading

Ilya (iSazonov) commented Nov 8, 2017 •

edited

Loading

Vinod Chandru (vinodc) commented Feb 22, 2018 •

edited

Loading

Drey Tee (dreyTee) commented May 5, 2019 •

edited

Loading