Skip to content

Exclude EventResource.resx from SMAResources.Tests.ps1 - #5379

Merged
Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:masterfrom
dantraMSFT:dantra/issue5378
Nov 9, 2017
Merged

Exclude EventResource.resx from SMAResources.Tests.ps1#5379
Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:masterfrom
dantraMSFT:dantra/issue5378

Conversation

@dantraMSFT

@dantraMSFT Dan Travison (dantraMSFT) commented Nov 8, 2017

Copy link
Copy Markdown
Contributor

[Feature]
Fix #5378
EventResource.resx does not have a generated C# class.

@daxian-dbw

Copy link
Copy Markdown
Member

Dan Travison (@dantraMSFT) the [Feature] needs to be put in the commit message, not in the PR description.

@SteveL-MSFT

Copy link
Copy Markdown
Member

Dan Travison (@dantraMSFT) on this branch, just do a git commit --amended and update the commit message so that the first line is [Feature], then git push --force

@daxian-dbw

Copy link
Copy Markdown
Member

Something is wrong with the macOS CI. The log shows the build passed, however the CI itself is shown as broken: https://travis-ci.org/PowerShell/PowerShell/jobs/299363616

I will merge this PR.

@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 7a78fec into PowerShell:master Nov 9, 2017
@dantraMSFT
Dan Travison (dantraMSFT) deleted the dantra/issue5378 branch November 9, 2017 17:39
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants