Core: Update JDBC catalog namespaces#4220
Merged
Merged
Conversation
| } | ||
|
|
||
| return (insertedProperties && updatedProperties); | ||
| return hadInserts || hadUpdates; |
Contributor
There was a problem hiding this comment.
This may be out of scope for this PR, but these operations don't appear to be atomic.
danielcweeks
approved these changes
Feb 25, 2022
danielcweeks
left a comment
Contributor
There was a problem hiding this comment.
Might want to create an issue for the setProperties not being atomic, but that is somewhat unrelated to these changes.
Contributor
Author
I think we're about as close as we can get to atomic with generic SQL since there is no standard way to upsert. I've also thought about doing a unique versioned insert and then dropping old versions. That could work to make it slightly more atomic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a few issues with the JDBC catalog's namespace implementation:
loadNamespaceMetadataNoSuchNamespaceExceptionthrown indropNamespace(returnfalseinstead)dropNamespacewhen the namespace exists because properties are set (will remove all properties)removePropertiesandsetPropertiesas noopsloadNamespaceMetadatarather than directly using thefetchPropertieshelper method