Core: Clean up JDBC implementation, add catalog namespace tests#4231
Merged
Conversation
| return execute(err -> {}, sql, args); | ||
| } | ||
|
|
||
| private int execute(Consumer<SQLException> sqlErrorHandler, String sql, String... args) { |
Contributor
There was a problem hiding this comment.
Error handler seems unnecessary since it's never used and throws anyway (as opposed to delegating to the handler).
Contributor
Author
There was a problem hiding this comment.
This is used in one case: https://github.com/apache/iceberg/pull/4231/files#diff-a5f7966c7493d463facbf7e76fe0fa3db1b637d29ee12e5b3628a5e5dd289e0aR195
I did this to avoid having a SQLException try/catch in every method.
Contributor
There was a problem hiding this comment.
Makes sense. Missed that usage.
danielcweeks
approved these changes
Feb 25, 2022
danielcweeks
approved these changes
Feb 25, 2022
Contributor
Author
|
Thanks for the review, @danielcweeks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This continues cleaning up the JDBC implementation after #4220 and adds namespace tests to validate the behavior of the JDBC catalog and other catalogs that support namespace properties.
fetch,exists, andexecutehelper methods