Support DO_NOT_TRACK=1 - #14924
Conversation
🦋 Changeset detectedLatest commit: 3a0fce3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codeowners approval required for this PR:
Show detailed file reviewers |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
@cloudflare/autoconfig
@cloudflare/build-output-utils
@cloudflare/config
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-functions
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
1c98d0a to
569fefc
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
edmundhung
left a comment
There was a problem hiding this comment.
We like the idea. Thanks for the PR!
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
09c6c76 to
b3a2221
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
d31ea24 to
a10f1a5
Compare
|
Codeowners approval required for this PR:
Show detailed file reviewers |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull request overview
Adds cross-tool support for the DO_NOT_TRACK environment variable as a universal telemetry opt-out, aligning Wrangler and Create Cloudflare behavior while centralizing parsing/precedence logic in @cloudflare/workers-utils.
Changes:
- Document
DO_NOT_TRACK=1telemetry opt-out (and precedence) in Wrangler and Create Cloudflare telemetry docs. - Add shared
DO_NOT_TRACKparsing (isDoNotTrackEnabled()) and integrate it into Wrangler’s telemetry resolution path. - Update Create Cloudflare telemetry enablement/status resolution and add/extend tests in both packages.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/wrangler/telemetry.md | Documents DO_NOT_TRACK=1 as a telemetry opt-out with highest precedence. |
| packages/wrangler/src/tests/metrics.test.ts | Adds coverage ensuring DO_NOT_TRACK=1 disables telemetry and overrides other settings. |
| packages/workers-utils/src/environment-variables/misc-variables.ts | Introduces isDoNotTrackEnabled() and applies it to Wrangler telemetry env resolution. |
| packages/workers-utils/src/environment-variables/factory.ts | Adds DO_NOT_TRACK to the supported environment variable name union. |
| packages/create-cloudflare/telemetry.md | Documents DO_NOT_TRACK=1 as a telemetry opt-out with highest precedence. |
| packages/create-cloudflare/src/metrics.ts | Implements DO_NOT_TRACK-aware telemetry resolution and status reporting. |
| packages/create-cloudflare/src/tests/metrics.test.ts | Adds tests for DO_NOT_TRACK behavior and status output; improves test cleanup. |
| .changeset/wrangler-do-not-track.md | Releases Wrangler change as a minor feature. |
| .changeset/workers-utils-do-not-track.md | Releases shared DO_NOT_TRACK utilities as a minor feature. |
| .changeset/nine-taxis-shave.md | Releases Create Cloudflare change as a minor feature. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
Codeowners approval required for this PR:
Show detailed file reviewers |
Adds support for the
DO_NOT_TRACKenvironment variable in both Wrangler &create-cloudflarealongside their unique opt out environment variables.A picture of a cute animal (not mandatory, but encouraged)
A photo of a pretty bird I saw a couple days ago (does anyone know what bird it is?)