Skip to content

[create-cloudflare] Pass pnpm settings through Turbo - #15067

Merged
edmundhung merged 1 commit into
mainfrom
edmundhung/fix-c3-pnpm-11-env
Aug 11, 2026
Merged

[create-cloudflare] Pass pnpm settings through Turbo#15067
edmundhung merged 1 commit into
mainfrom
edmundhung/fix-c3-pnpm-11-env

Conversation

@edmundhung

@edmundhung edmundhung commented Aug 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Pass the pnpm 11 pmOnFail and verifyDepsBeforeRun settings through Turbo for C3 E2E tests.

Fork PRs run Turbo in strict mode because they do not receive remote-cache secrets, so these workflow settings were being dropped. Version Packages runs in loose mode, which is why it passed. Declaring the settings in turbo.json makes both trusted and fork runs use the intended pnpm version while retaining pnpm 10 compatibility.

This blocks #14924 from being merged 😅

  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because: this only forwards existing CI environment settings through Turbo; the C3 E2E matrix exercises the affected path
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: this is an internal CI configuration fix

A picture of a cute animal (not mandatory, but encouraged)

Open in Devin Review

@changeset-bot

changeset-bot Bot commented Aug 6, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8d4a1e4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@edmundhung edmundhung added the ci:no-changeset-required Skip pull request checks for a valid changeset label Aug 6, 2026
devin-ai-integration[bot]
devin-ai-integration Bot reviewed Aug 6, 2026
View reviewed changes

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@edmundhung edmundhung added the run-c3-frameworks-tests Run all the C3 frameworks tests on this PR label Aug 7, 2026
@workers-devprod
workers-devprod requested review from a team and emily-shen and removed request for a team August 7, 2026 10:03
@workers-devprod

workers-devprod commented Aug 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@edmundhung
edmundhung force-pushed the edmundhung/fix-c3-pnpm-11-env branch from 3c3792a to 2f32ae2 Compare August 7, 2026 11:14
@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Aug 7, 2026
@pkg-pr-new

pkg-pr-new Bot commented Aug 7, 2026 •
edited
Loading

Copy link
Copy Markdown
@cloudflare/autoconfig

npm i https://pkg.pr.new/@cloudflare/autoconfig@15067

@cloudflare/build-output-utils

npm i https://pkg.pr.new/@cloudflare/build-output-utils@15067

@cloudflare/config

npm i https://pkg.pr.new/@cloudflare/config@15067

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@15067

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@15067

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@15067

miniflare

npm i https://pkg.pr.new/miniflare@15067

@cloudflare/pages-functions

npm i https://pkg.pr.new/@cloudflare/pages-functions@15067

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@15067

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@15067

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@15067

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@15067

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@15067

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@15067

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@15067

wrangler

npm i https://pkg.pr.new/wrangler@15067

commit: 8d4a1e4

@petebacondarwin

petebacondarwin commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

This appears to break a lot of C3 CI...

@edmundhung
edmundhung marked this pull request as draft August 7, 2026 13:01
@edmundhung
edmundhung force-pushed the edmundhung/fix-c3-pnpm-11-env branch from 2f32ae2 to 8d4a1e4 Compare August 11, 2026 10:10
@edmundhung
edmundhung marked this pull request as ready for review August 11, 2026 10:49
@petebacondarwin
petebacondarwin removed the request for review from emily-shen August 11, 2026 11:40
@petebacondarwin

petebacondarwin commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

I believe the PR description is not accurate. At least in CI I think we run turbo in strict mode, hence the need to add these?

workers-devprod
workers-devprod approved these changes Aug 11, 2026
View reviewed changes

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Aug 11, 2026
@edmundhung

edmundhung commented Aug 11, 2026

Copy link
Copy Markdown
Member Author

@petebacondarwin We do echo "TURBO_ENV_MODE=loose" >> $GITHUB_ENV in https://github.com/cloudflare/workers-sdk/blob/main/.github/actions/install-dependencies/action.yml#L58

You can see the VP PR logged this too: https://github.com/cloudflare/workers-sdk/actions/runs/31407924446/job/93518674222#step:5:104

@edmundhung

edmundhung commented Aug 11, 2026

Copy link
Copy Markdown
Member Author

To clarify: We run CI in strict mode only on forks PR as the setup I mentioned above will run only if input.turbo-api is set, and that would be missing if the PR comes from a fork.

@edmundhung
edmundhung merged commit a2129b8 into main Aug 11, 2026
70 of 74 checks passed
@edmundhung
edmundhung deleted the edmundhung/fix-c3-pnpm-11-env branch August 11, 2026 12:39
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments
@petebacondarwin petebacondarwin petebacondarwin approved these changes
@workers-devprod workers-devprod workers-devprod approved these changes

Assignees

No one assigned

Labels

ci:no-changeset-required Skip pull request checks for a valid changeset run-c3-frameworks-tests Run all the C3 frameworks tests on this PR

Projects

workers-sdk
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@edmundhung @workers-devprod @petebacondarwin