Skip to content

WC-5618 add preview base-config secret commands - #15079

Merged
dario-piotrowicz merged 8 commits into
cloudflare:mainfrom
podonnell-dev:podonnell/WC-5618-use-patch-apis-base-config
Aug 10, 2026
Merged

WC-5618 add preview base-config secret commands#15079
dario-piotrowicz merged 8 commits into
cloudflare:mainfrom
podonnell-dev:podonnell/WC-5618-use-patch-apis-base-config

Conversation

@podonnell-dev

@podonnell-dev podonnell-dev commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Fixes WC-5618

This PR only covers d9ac0cc - as a follow-up to #15043

Add wrangler preview base-config secret commands - bulk, list, put, delete
Using same patch APIs as #15043

Reviewable, but ask Patrick before merging - we'll be trying to time this release for Tuesday's release


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: private beta

A picture of a cute animal (not mandatory, but encouraged)


Open in Devin Review

@changeset-bot

changeset-bot Bot commented Aug 7, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9e64881

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
wrangler Minor
@cloudflare/vite-plugin Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@workers-devprod
workers-devprod requested review from a team and NuroDev and removed request for a team August 7, 2026 15:43
@workers-devprod

workers-devprod commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

@podonnell-dev
podonnell-dev force-pushed the podonnell/WC-5618-use-patch-apis-base-config branch from f973083 to 8af05eb Compare August 7, 2026 16:21
@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Aug 7, 2026
@pkg-pr-new

pkg-pr-new Bot commented Aug 7, 2026

Copy link
Copy Markdown
@cloudflare/autoconfig

npm i https://pkg.pr.new/@cloudflare/autoconfig@15079

@cloudflare/build-output-utils

npm i https://pkg.pr.new/@cloudflare/build-output-utils@15079

@cloudflare/config

npm i https://pkg.pr.new/@cloudflare/config@15079

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@15079

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@15079

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@15079

miniflare

npm i https://pkg.pr.new/miniflare@15079

@cloudflare/pages-functions

npm i https://pkg.pr.new/@cloudflare/pages-functions@15079

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@15079

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@15079

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@15079

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@15079

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@15079

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@15079

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@15079

wrangler

npm i https://pkg.pr.new/wrangler@15079

commit: 9e64881

@podonnell-dev
podonnell-dev force-pushed the podonnell/WC-5618-use-patch-apis-base-config branch 2 times, most recently from be400ba to f4dfd4c Compare August 10, 2026 13:06
@dario-piotrowicz
dario-piotrowicz requested review from dario-piotrowicz and removed request for NuroDev August 10, 2026 15:03

@dario-piotrowicz dario-piotrowicz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with some minor comments/suggestions

Comment thread packages/wrangler/src/__tests__/preview.base-config.secret.test.ts Outdated
Comment thread packages/wrangler/src/preview/secrets/list.ts Outdated
Comment thread packages/wrangler/src/preview/secrets/delete.ts Outdated
Comment thread packages/wrangler/src/preview/secrets/bulk.ts Outdated
Comment thread packages/wrangler/src/preview/base-config/secrets/index.ts Outdated
Comment thread packages/wrangler/src/__tests__/preview.secret.test.ts Outdated

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Aug 10, 2026
@podonnell-dev
podonnell-dev force-pushed the podonnell/WC-5618-use-patch-apis-base-config branch from fca10bc to 3ea0ae6 Compare August 10, 2026 17:19
@podonnell-dev
podonnell-dev force-pushed the podonnell/WC-5618-use-patch-apis-base-config branch from 3ea0ae6 to 9e64881 Compare August 10, 2026 17:52
@dario-piotrowicz
dario-piotrowicz merged commit 15cad03 into cloudflare:main Aug 10, 2026
55 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants