Skip to content

WC-5618 add preview base-config secret commands #15079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dario-piotrowicz merged 8 commits into from
Aug 10, 2026
+2,611 −817
Merged

WC-5618 add preview base-config secret commands #15079

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
863d56c
WC-5233 Use PATCH APIs for wrangler preview secret put and delete
podonnell-dev Aug 4, 2026
4deb16b
WC-5233 Add preview secret list and bulk
podonnell-dev Aug 5, 2026
5256c6c
WC-5233 restructure commands
podonnell-dev Aug 5, 2026
69db48b
WC-5233 enhance messages, add delete on empty for bulk, fix tests
podonnell-dev Aug 6, 2026
8a38c04
WC-5233 match repo conventions, adjust preview list message
podonnell-dev Aug 7, 2026
0a14e4e
WC-5233 fix: leaky test
podonnell-dev Aug 10, 2026
218b337
WC-5168 add preview base-config secrets commands
podonnell-dev Aug 7, 2026
9e64881
WC-5618 update no deployments message, enhance tests
podonnell-dev Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
WC-5233 fix: leaky test
  • Loading branch information
@podonnell-dev
podonnell-dev committed Aug 10, 2026
commit 0a14e4ec57628add1d53b444a1f65944642ebc32
41 changes: 33 additions & 8 deletions packages/wrangler/src/__tests__/preview.secret.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,34 @@ type PreviewDeploymentPatchBody = {
annotations?: Record<string, string | undefined>;
};

const BRANCH_ENV_VARS = [
"WORKERS_CI_BRANCH",
"GITHUB_HEAD_REF",
"GITHUB_REF_NAME",
"CI_COMMIT_REF_NAME",
] as const;

async function withoutBranchEnvVars<T>(callback: () => Promise<T>): Promise<T> {
const originalBranchEnv = Object.fromEntries(
BRANCH_ENV_VARS.map((envVar) => [envVar, process.env[envVar]])
);
for (const envVar of BRANCH_ENV_VARS) {
delete process.env[envVar];
}
try {
return await callback();
} finally {
for (const envVar of BRANCH_ENV_VARS) {
const originalValue = originalBranchEnv[envVar];
if (originalValue === undefined) {
delete process.env[envVar];
} else {
process.env[envVar] = originalValue;
}
}
}
}

function mockPatchLatestPreviewDeployment(
onRequest?: (info: { url: string; body: PreviewDeploymentPatchBody }) => void
) {
Expand Down Expand Up @@ -185,14 +213,11 @@ describe("wrangler preview", () => {
// `runInTempDir` puts us in an `os.tmpdir()` directory that is not a
// git worktree, so with no CI branch env vars the Preview name
// cannot be inferred.
vi.stubEnv("WORKERS_CI_BRANCH", undefined);
vi.stubEnv("GITHUB_HEAD_REF", undefined);
vi.stubEnv("GITHUB_REF_NAME", undefined);
vi.stubEnv("CI_COMMIT_REF_NAME", undefined);

await expect(
runWrangler("preview secret put API_KEY --worker-name test-worker")
).rejects.toThrow(/Could not determine Preview name/);
await withoutBranchEnvVars(() =>
expect(
runWrangler("preview secret put API_KEY --worker-name test-worker")
).rejects.toThrow(/Could not determine Preview name/)
);
});

test("respects env-specific worker name when using --env", async ({
Expand Down