Update lift-mongodb and lift-mongodb-record for deprecations in the m… - #1977
Closed
eltimn wants to merge 1 commit into
Closed
Update lift-mongodb and lift-mongodb-record for deprecations in the m…#1977eltimn wants to merge 1 commit into
eltimn wants to merge 1 commit into
Conversation
eltimn
force-pushed
the
tcn_issue_1830
branch
2 times, most recently
from
October 21, 2019 11:19
2af12d5 to
eff16b8
Compare
Member
|
Any word here Tim? |
Member
Author
|
Got real busy at work. I'm hoping to get back to this in the next couple of weeks. |
Member
|
No judgement here. Toddler is keeping me plenty busy too. 😂 |
…ongo-java-driver. Enable Scala 2.13 for lift-mongodb and lift-mongodb-record.
Member
Author
|
Superceded by #1984 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ongo-java-driver.
Fixes #1830
The mongo-java-driver has deprecated a lot of their classes and are going to remove them in the next release. This is long overdue.
One of the big changes is the use of a codec model for encoding and decoding data to/from the db into a language type. I took advantage of that to change how Records are stored. A RecordCodec is now used, which means data is put directly into a Record instead of first being put into a DBObject (or the newer Document) and then converting from there. I didn't do any benchmarks, but I would think that's a decent performance improvement.
I'm not 100% sure if I'm done with this yet, but I wanted to get this up. I need to set it aside for a couple of weeks while I get back to my job. The main thing I'm still thinking about doing is replacing the BsonParser with a Codec for JValue. I have a lot of it written already, but I'm not sure it's worth the effort to finish it.