Update lift-mongodb and lift-mongodb-record for deprecations in the m… - #1984
Merged
Conversation
…ongo-java-driver. Enable Scala 2.13 for lift-mongodb and lift-mongodb-record.
farmdawgnation
approved these changes
Jul 3, 2020
farmdawgnation
left a comment
Member
There was a problem hiding this comment.
This is a lot of code for one PR but I trust you. 😅
| import org.bson.codecs.BsonTypeClassMap | ||
| import org.bson.codecs.configuration.CodecRegistry | ||
|
|
||
| object MongoRecordRules extends SimpleInjector { |
Member
There was a problem hiding this comment.
Some Scaladoc here would be helpful for folks just trying to figure out what this is at the class level.
Member
Author
There was a problem hiding this comment.
Good idea. I added a short description.
fmpwizard
approved these changes
Jul 5, 2020
Member
Author
|
I'm going to close and re-open this to trigger a travis build. |
Member
Author
|
Ok, I think we're good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ongo-java-driver. Enable Scala 2.13 for lift-mongodb and lift-mongodb-record.
Fixes #1830
Supercedes #1977
Since there haven't been any replies to my ml thread about the async parts I've chosen to deprecate them. If someone comes along later and wants to use them we can update them at that point.
I'm running this locally with my app (rotozen.com) and all is working ok. I'll be testing it for a few more days since the app does different things depending on the day of the week.