Allowing agent to skip unimplemented key types. - #134
Closed
pnabutovsky wants to merge 1 commit into
Closed
Conversation
bobveznat
added a commit
to bobveznat/net-ssh
that referenced
this pull request
Jan 21, 2014
This does not implement certificate based authentication (described here http://www.openbsd.org/cgi-bin/cvsweb/src/usr.bin/ssh/PROTOCOL.certkeys?rev=HEAD) but instead makes it so that if the certificate is not needed for authentication net-ssh doesn't cause the entire application to die. The net-ssh test suite continues to pass. On my own machine I did tests with certificates loaded and verified that although authentication could not proceed to a host requiring a certificate it at least did not die. I also verified that I can continue to use normal rsa and dsa keys to ssh to hosts that do not require certificates even when the certificates are loaded into my ssh-agent instance. This is a potential solution to issue net-ssh#124 and an alternative to the one presented in pull request net-ssh#134.
Collaborator
|
Thanks for looking into this. I decided to go with the solution in #142 as it didn't change current functionality. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When net-ssh reads keys from the SSH agent it breaks when it encounters an unknown key type. Since the library does not implement certified RSA keys this is somewhat noticeable. The pull request is by no means a fix: the real solution is to implement the cert keys. I recognize that with my patch the agent will fail almost-silently, but I consider that the lesser of two evils.