Handle ssh-rsa and ssh-dss certificate files - #142
Merged
Conversation
This does not implement certificate based authentication (described here http://www.openbsd.org/cgi-bin/cvsweb/src/usr.bin/ssh/PROTOCOL.certkeys?rev=HEAD) but instead makes it so that if the certificate is not needed for authentication net-ssh doesn't cause the entire application to die. The net-ssh test suite continues to pass. On my own machine I did tests with certificates loaded and verified that although authentication could not proceed to a host requiring a certificate it at least did not die. I also verified that I can continue to use normal rsa and dsa keys to ssh to hosts that do not require certificates even when the certificates are loaded into my ssh-agent instance. This is a potential solution to issue net-ssh#124 and an alternative to the one presented in pull request net-ssh#134.
Collaborator
|
Looks good, all tests pass. Thanks. |
delano
added a commit
that referenced
this pull request
Jan 23, 2014
Handle ssh-rsa and ssh-dss certificate files
Author
|
@delano, thanks for accepting this pull request. Are there plans to tag a new release soon? Mitchell from Vagrant has agreed to do a new release of Vagrant once this patch is into a release of net-ssh. |
|
+1 for a new tagged release to get this into Vagrant |
Collaborator
|
I'll push a release this weekend. |
This was referenced Feb 1, 2014
|
// , Someone needs to update the notes for https://pypi.python.org/pypi/ssh-ca/0.3.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does not implement certificate based authentication (described here
http://www.openbsd.org/cgi-bin/cvsweb/src/usr.bin/ssh/PROTOCOL.certkeys?rev=HEAD)
but instead makes it so that if the certificate is not needed for
authentication net-ssh doesn't cause the entire application to die.
The net-ssh test suite continues to pass. On my own machine I did tests
with certificates loaded and verified that although authentication could
not proceed to a host requiring a certificate it at least did not die.
I also verified that I can continue to use normal rsa and dsa keys to
ssh to hosts that do not require certificates even when the certificates
are loaded into my ssh-agent instance.
This is a potential solution to issue #124 and an alternative to the one
presented in pull request #134.