feat(slider): new TEDI-ready component #3 - #526

tedi/components/form/slider/slider.component.html (1)

48-51: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

BEM element notation used on a sub-component.

.tedi-slider__thumb-anchor is applied to <tedi-tooltip-trigger>, which is its own Angular component, not a simple DOM node of tedi-slider. Per guidelines, sub-components that are their own Angular components should get a separate BEM block rather than an __element of the parent block.

♻️ Proposed fix

-        <tedi-tooltip-trigger
-          class="tedi-slider__thumb-anchor"
-          [interactive]="false"
-        ></tedi-tooltip-trigger>
+        <tedi-tooltip-trigger
+          class="tedi-slider-thumb-anchor"
+          [interactive]="false"
+        ></tedi-tooltip-trigger>

(rename the matching selector in slider.component.scss accordingly)

As per coding guidelines, "use separate BEM blocks for sub-components that are their own Angular components, and use `__` elements only for simple DOM nodes within a single component template."

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tedi/components/form/slider/slider.component.html` around lines 48 - 51, The
`tedi-slider__thumb-anchor` class is using parent block element BEM notation on
the standalone `tedi-tooltip-trigger` sub-component, which should have its own
block name instead. Update the class in `slider.component.html` to a separate
BEM block for the tooltip trigger, and rename the matching selector in
`slider.component.scss` so the styling stays aligned with the new class name.

Source: Coding guidelines

tedi/components/form/slider/slider.stories.ts (1)

44-131: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Missing argTypes entries for some public inputs.

name, ariaLabel, ariaLabelledby, and ariaValuetext are public SliderComponent inputs (and ariaLabel is even used as an arg override in other stories) but have no argTypes entry, so they won't show up in the Storybook controls/docs table.

♻️ Proposed fix

     valueFormatter: { control: false },
     inputId: { control: false },
+    name: {
+      control: "text",
+      table: { category: "inputs", type: { summary: "string" } },
+    },
+    ariaLabel: {
+      control: "text",
+      table: { category: "inputs", type: { summary: "string" } },
+    },
+    ariaLabelledby: {
+      control: "text",
+      table: { category: "inputs", type: { summary: "string" } },
+    },
+    ariaValuetext: {
+      control: "text",
+      table: { category: "inputs", type: { summary: "string" } },
+    },
   },

As per path instructions, "ensure `argTypes` includes every public input/model, provide a Default story, and include significant state/visual variants."

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tedi/components/form/slider/slider.stories.ts` around lines 44 - 131, The
Slider story’s argTypes block is missing several public inputs, so add entries
for name, ariaLabel, ariaLabelledby, and ariaValuetext alongside the existing
SliderComponent controls. Update the slider.stories.ts argTypes definition so
these props appear in Storybook docs/controls, matching the pattern used for
label, value, and the other inputs. Keep the Default story and other variants
intact while ensuring every public input/model is represented.

Source: Path instructions

tedi/components/overlay/tooltip/tooltip-trigger/tooltip-trigger.component.ts (1)

140-142: 🎯 Functional Correctness | 🔵 Trivial

No cleanup when interactive toggles from true to false.

The early return skips resolving/attaching a new interactive element, but any DOM mutations from a prior pass while interactive was true (injected <span> wrapper, tabindex, tedi-tooltip-trigger--focus class, aria-describedby) are never undone. The spec file avoids exercising this transition by creating a fresh fixture for the interactive: false case rather than toggling on the same instance, suggesting this gap is already known.

At minimum, reset interactiveElement to null on the "no longer interactive" branch so aria-describedby doesn't linger on a stale element; a full fix would also need to track and revert the tabindex/class/wrapper changes made when interactive was previously true.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tedi/components/overlay/tooltip/tooltip-trigger/tooltip-trigger.component.ts`
around lines 140 - 142, The interactive toggle path in
tooltip-trigger.component.ts leaves prior DOM changes behind when `interactive`
switches from true to false. Update `ngAfterContentChecked` in
`TooltipTriggerComponent` so the non-interactive branch clears
`interactiveElement` and also reverts any state applied during the interactive
path, including the injected wrapper, tabindex, `tedi-tooltip-trigger--focus`
class, and `aria-describedby` on the trigger element.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

tedi/components/overlay/tooltip/tooltip.stories.ts (1)

75-89: 📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win

Still missing argTypes for open and trackPosition.

This was previously flagged: the newly added TooltipComponent inputs open (model) and trackPosition have no corresponding argTypes entries, so they won't appear in Storybook controls/docs. A "Controlled" story variant demonstrating openWith="none" + open + trackPosition is also still absent.

As per path instructions, "document every public input()/model() in argTypes" and "include Default story plus per-visual-variant and per-significant-state stories."

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tedi/components/overlay/tooltip/tooltip.stories.ts` around lines 75 - 89, Add
the missing Storybook documentation for TooltipComponent by updating
TooltipComponent stories to include argTypes entries for the public model/input
properties open and trackPosition alongside the existing openWith setup, so they
appear in controls/docs. Also add a new “Controlled” story variant using
TooltipComponent with openWith="none" plus open and trackPosition wired in,
following the existing story patterns in tooltip.stories.ts.

Source: Path instructions