Skip to content

fix(date-field): date-field now passes value correctly to text-field #592 - #593

Merged
mart-sessman merged 1 commit into
rcfrom
fix/592-datefield-visible-input-not-updating
Aug 5, 2026
Merged

fix(date-field): date-field now passes value correctly to text-field #592#593
mart-sessman merged 1 commit into
rcfrom
fix/592-datefield-visible-input-not-updating

Conversation

@mart-sessman

@mart-sessman mart-sessman commented Aug 5, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Fixed date field inputs so they correctly display initial and externally updated form values.
    • Improved synchronization between date field values and the visible input.

@mart-sessman mart-sessman added the priority: severe It breaks the basic usage of the component label Aug 5, 2026
@coderabbitai

coderabbitai Bot commented Aug 5, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 620a0522-93f6-4276-a776-34a792df04c3

📥 Commits

Reviewing files that changed from the base of the PR and between 95fa1ee and 3cee2ea.

📒 Files selected for processing (3)
  • tedi/components/form/date-field/date-field.component.spec.ts
  • tedi/components/form/date-field/date-input/date-input.component.html
  • tedi/components/form/date-field/date-input/date-input.component.ts
💤 Files with no reviewable changes (1)
  • tedi/components/form/date-field/date-input/date-input.component.ts
📝 Walkthrough

Walkthrough

The date input now binds its displayed value directly to inputValue(). The previous synchronization effect was removed. A reactive-form regression test verifies that external FormControl updates reach the nested text field and its rendered input.

Changes

Date input synchronization

Layer / File(s) Summary
Bind the native input to inputValue()
tedi/components/form/date-field/date-input/date-input.component.html, tedi/components/form/date-field/date-input/date-input.component.ts		 The native input reads its value from inputValue(). The previous value synchronization effect was removed.
Verify reactive-form updates
tedi/components/form/date-field/date-field.component.spec.ts		 The test checks initial and subsequent external FormControl value updates in the nested text field and rendered input.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: airikej, ly-tempel-bitweb

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main fix: passing the date-field value correctly to the nested text field.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/592-datefield-visible-input-not-updating

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

♿ Accessibility — ✅ no blocking violations

No accessibility violations in the components changed by this PR.

⚠️ Pre-existing — 6 violations in components not changed here (warn only)

Component Rules Stories
TEDI-Ready/Components/Form/InputGroup aria-input-field-name ×3 3
TEDI-Ready/Components/Form/Search landmark-unique ×2, aria-allowed-attr 3
Stories

🔕 Known issues — 21 stories marked todo (warn only)

Stories

@mart-sessman
mart-sessman merged commit 5bc496e into rc Aug 5, 2026
28 checks passed
@mart-sessman
mart-sessman deleted the fix/592-datefield-visible-input-not-updating branch August 5, 2026 13:45
github-actions Bot pushed a commit that referenced this pull request Aug 5, 2026
@semantic-release-bot
chore(release): 7.1.0-rc.21
70c326f 
# [7.1.0-rc.21](angular-7.1.0-rc.20...angular-7.1.0-rc.21) (2026-08-05)

### Bug Fixes

* **date-field:** date-field now passes value correctly to text-field [#592](#592) ([#593](#593)) ([5bc496e](5bc496e))
github-actions Bot pushed a commit that referenced this pull request Aug 6, 2026
@semantic-release-bot
chore(release): 7.1.0
4c4afbc 
# [7.1.0](angular-7.0.1...angular-7.1.0) (2026-08-06)

### Bug Fixes

* **date-field:** changed min and max date defaults, exposed inputs [#590](#590) ([#591](#591)) ([30edbb3](30edbb3))
* **date-field:** date-field now passes value correctly to text-field [#592](#592) ([#593](#593)) ([5bc496e](5bc496e))
* **date-picker:** fix DatePicker focus ring [#560](#560) ([#574](#574)) ([17f675d](17f675d))
* **dropdown:** skip close on certain events [#544](#544) ([#545](#545)) ([f9be659](f9be659))
* **form-field,date-field,text-field,time-field:** value no longer cuts early [#561](#561) ([#571](#571)) ([17322fc](17322fc))
* **pagination:** community pagination results rendered twice [#548](#548) ([2ba2bb3](2ba2bb3))
* **popover,search,header:** fix Header a11y violations and document HeaderTop [#601](#601) ([#602](#602)) ([86312a9](86312a9))
* **popover:** fixed popover outside-click inside modal being registered as inside [#582](#582) ([#583](#583)) ([139406b](139406b))
* **select,dropdown,popover:** hideOnScroll no longer closes overlay when scrolling its content [#562](#562) ([#567](#567)) ([3120825](3120825))
* **select:** keep typed text and tags in view while searching [#566](#566) ([#584](#584)) ([6afc148](6afc148))
* **select:** truncate over-wide tags in a single row [#586](#586) ([#598](#598)) ([68dcb27](68dcb27))
* **table:** scrollable table now scrolls top on page change [#549](#549) ([#550](#550)) ([9771fc3](9771fc3))
* **tabs:** added anchor support [#594](#594) ([#597](#597)) ([c9a3a98](c9a3a98))
* **text-field,time-field:** caret no longer clipped at the start of the input [#575](#575) ([#576](#576)) ([644d3f5](644d3f5))
* **text-field:** support bare disabled attribute via booleanAttribute transform [#558](#558) ([#559](#559)) ([fad56f8](fad56f8))
* **textgroup:** label doesn't shrink when width is fixed [#506](#506) ([#531](#531)) ([4e9d713](4e9d713))

### Features

* **breadcrumbs:** new TEDI-ready component [#512](#512) ([#518](#518)) ([6691cd2](6691cd2))
* **date-field:** added hideOnScroll [#563](#563) ([#595](#595)) ([0dfad0f](0dfad0f))
* **header:** add Header top [#311](#311) ([#504](#504)) ([1e2eff2](1e2eff2))
* **info-button:** focus ring offset reduced [#517](#517) ([#521](#521)) ([b7d06d3](b7d06d3))
* **input-group:** new TEDI-ready component [#18](#18) ([#532](#532)) ([c1728c0](c1728c0))
* **label-row,info-tooltip:** new components [#515](#515) ([#525](#525)) ([1e33865](1e33865))
* **popover:** add Header popover variant under Popover [#442](#442) ([#523](#523)) ([a668b55](a668b55))
* **search:** add new TEDI-ready component [#524](#524) ([#539](#539)) ([f637542](f637542))
* **select:** added virtual scroll [#552](#552) ([#553](#553)) ([26e10ee](26e10ee))
* **slider:** new TEDI-ready component [#3](#3) ([#526](#526)) ([d2bf13a](d2bf13a))
* **table:** added getRowId and clearFilters [#565](#565) ([#589](#589)) ([1cf94a1](1cf94a1))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@airikej airikej airikej approved these changes
@ly-tempel-bitweb ly-tempel-bitweb ly-tempel-bitweb approved these changes

Assignees

No one assigned

Labels

priority: severe It breaks the basic usage of the component

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mart-sessman @airikej @ly-tempel-bitweb